Remove both of them, and remove locale from the list of supported blueprint options in the image definitions yaml.

@brlane-rht wait, is this missing from the PR? I can't see any change to the image definition yaml

@brlane-rht wait, is this missing from the PR? I can't see any change to the image definition yaml

ugh. github doesn't update the PR description after the first push, locale is still allowed in the yaml because it can be used to set the iso's language. I'll fix the description to match the current state :)

The network installer does not use these values to create a kickstart. The blueprint Locale is used for the locale of the booted iso, not the installed system. The timezone customization is not used at all. But setting these triggers creation of an empty osbuild.ks which causes Anaconda to crash.

This removes the code that was setting these in the Kickstart struct. Locale is still set in the installer using org.osbuild.locale

This includes new manifest tests that only set customizations.locale in the blueprint which will create an org.osbuild.locale stage, but NOT an org.osbuild.kickstart stage.

Resolves: HMS-10469

What I'm confused about is; don't we want to create a kickstart when the timezone or locale is provided in customizations? AFAIK it's OK to have a kickstart for customizations, just not if none are provided.

Shouldn't in that case the fix be the other way around, to actually propagate these values in the kickstart?